Don't complain about BAD code you come across, Just fix it. Usually you are not privy to the exact situation surrounding the code you see before you.
It's easy to criticize older code someone else has written, but we have all written code that could be better.
Ever come across a section of code, and say to your self... "Whoa! This sucks!” I wonder what the developer was thinking here.
Then you look further down and realize you wrote it 2 years ago late at night when you had the flu.
+
=
You can almost always refactor your code to make it more streamlined, readable and efficient. But not everyone has the time, or makes time to do so.
The important message here is to "Just fix it " but be carefull there could be good reasons for the decisions made to code this solutiuon in a particular way.
More to come...